From f87f62f11154a83b76f81fb817abf60c51946e07 Mon Sep 17 00:00:00 2001
From: bisco <bisco@younerd.org>
Date: Wed, 3 Jun 2026 23:15:30 +0200
Subject: [PATCH] fix: allow returning from player detail to results

---
 frontend/src/app/app.component.css     | 28 +++++++++++++++++++++++++-
 frontend/src/app/app.component.html    | 13 +++++++-----
 frontend/src/app/app.component.spec.ts | 16 +++++++++++++++
 frontend/src/app/app.component.ts      | 18 ++++++++++++++---
 4 files changed, 66 insertions(+), 9 deletions(-)

diff --git a/frontend/src/app/app.component.css b/frontend/src/app/app.component.css
index 80c88bd..663cc93 100644
--- a/frontend/src/app/app.component.css
+++ b/frontend/src/app/app.component.css
@@ -126,6 +126,12 @@ button {
   background: #e7eeeb;
 }
 
+.compact {
+  min-height: 34px;
+  padding: 0 10px;
+  white-space: nowrap;
+}
+
 .sort {
   min-height: 30px;
   padding: 0 10px;
@@ -152,12 +158,16 @@ button {
 
 .workspace {
   display: grid;
-  grid-template-columns: minmax(0, 1fr) 390px;
+  grid-template-columns: minmax(0, 1fr);
   gap: 16px;
   margin-top: 14px;
   align-items: start;
 }
 
+.workspace.detail-open {
+  grid-template-columns: minmax(0, 1fr) 390px;
+}
+
 .table-wrap,
 .detail {
   background: var(--panel);
@@ -229,6 +239,13 @@ td small {
   top: 14px;
 }
 
+.detail-header {
+  display: flex;
+  align-items: flex-start;
+  justify-content: space-between;
+  gap: 12px;
+}
+
 .role {
   margin: 6px 0 0;
   color: var(--muted);
@@ -311,6 +328,10 @@ dd {
     grid-template-columns: 1fr;
   }
 
+  .workspace.detail-open {
+    grid-template-columns: 1fr;
+  }
+
   .table-wrap {
     max-height: none;
   }
@@ -364,6 +385,11 @@ dd {
   h1 {
     font-size: 2.6rem;
   }
+
+  .detail-header {
+    display: grid;
+    grid-template-columns: 1fr;
+  }
 }
 
 @media (max-width: 520px) {
diff --git a/frontend/src/app/app.component.html b/frontend/src/app/app.component.html
index 4c588ab..e13e1ea 100644
--- a/frontend/src/app/app.component.html
+++ b/frontend/src/app/app.component.html
@@ -81,7 +81,7 @@
 
   <p *ngIf="errorMessage" class="alert">{{ errorMessage }}</p>
 
-  <section class="workspace" aria-label="Scouting workspace">
+  <section class="workspace" [class.detail-open]="selectedPlayer" aria-label="Scouting workspace">
     <div class="table-wrap">
       <table>
         <thead>
@@ -129,10 +129,13 @@
     </div>
 
     <aside class="detail" *ngIf="selectedPlayer">
-      <div>
-        <p class="eyebrow">Selected profile</p>
-        <h2>{{ selectedPlayer.name }}</h2>
-        <p class="role">{{ selectedPlayer.position }} · {{ selectedPlayer.role || 'Role pending' }}</p>
+      <div class="detail-header">
+        <div>
+          <p class="eyebrow">Selected profile</p>
+          <h2>{{ selectedPlayer.name }}</h2>
+          <p class="role">{{ selectedPlayer.position }} · {{ selectedPlayer.role || 'Role pending' }}</p>
+        </div>
+        <button type="button" class="secondary compact" (click)="returnToResults()">Back to results</button>
       </div>
       <div class="profile-strip">
         <span>{{ selectedPlayer.nationality || '-' }}</span>
diff --git a/frontend/src/app/app.component.spec.ts b/frontend/src/app/app.component.spec.ts
index 254389d..a32303e 100644
--- a/frontend/src/app/app.component.spec.ts
+++ b/frontend/src/app/app.component.spec.ts
@@ -71,6 +71,7 @@ describe('AppComponent', () => {
     assert.equal(component.resultCount, 2);
     assert.equal(component.averagePoints, '14.00');
     assert.equal(component.topEfficiencyPlayer?.name, 'Luca Marini');
+    assert.equal(component.selectedPlayer, null);
   });
 
   it('reacts to filter changes without requiring the search button', () => {
@@ -131,4 +132,19 @@ describe('AppComponent', () => {
 
     assert.equal(component.players[0].name, 'Mateo Santos');
   });
+
+  it('opens and closes a player profile without losing the filtered list', () => {
+    const api = {
+      searchPlayers: () => of({ count: samplePlayers.length, results: samplePlayers }),
+    } as unknown as PlayerApiService;
+    const component = new AppComponent(api);
+
+    component.search();
+    component.selectPlayer(samplePlayers[0]);
+    component.returnToResults();
+
+    assert.equal(component.selectedPlayer, null);
+    assert.equal(component.players.length, 2);
+    assert.equal(component.resultCount, 2);
+  });
 });
diff --git a/frontend/src/app/app.component.ts b/frontend/src/app/app.component.ts
index f923d03..1341f95 100644
--- a/frontend/src/app/app.component.ts
+++ b/frontend/src/app/app.component.ts
@@ -84,9 +84,10 @@ export class AppComponent {
 
     this.playerApi.searchPlayers(this.filters).subscribe({
       next: (response) => {
-        this.players = this.sortPlayers(response.results);
+        const players = this.sortPlayers(response.results);
+        this.players = players;
         this.resultCount = response.count;
-        this.selectedPlayer = this.players[0] ?? null;
+        this.selectedPlayer = this.matchSelectedPlayer(players);
         this.loading = false;
       },
       error: () => {
@@ -126,13 +127,17 @@ export class AppComponent {
   sortBy(key: SortKey): void {
     this.activeSort = key;
     this.players = this.sortPlayers(this.players);
-    this.selectedPlayer = this.players[0] ?? null;
+    this.selectedPlayer = this.matchSelectedPlayer(this.players);
   }
 
   selectPlayer(player: PlayerSummary): void {
     this.selectedPlayer = player;
   }
 
+  returnToResults(): void {
+    this.selectedPlayer = null;
+  }
+
   statValue(player: PlayerSummary, key: keyof NonNullable<PlayerSummary['stats']>): string {
     const value = player.stats?.[key];
     return value === undefined || value === null ? '-' : String(value);
@@ -170,6 +175,13 @@ export class AppComponent {
     return Number(player.stats?.[key] ?? 0);
   }
 
+  private matchSelectedPlayer(players: PlayerSummary[]): PlayerSummary | null {
+    if (!this.selectedPlayer) {
+      return null;
+    }
+    return players.find((player) => player.id === this.selectedPlayer?.id) ?? null;
+  }
+
   private cancelPendingSearch(): void {
     if (this.pendingSearch) {
       clearTimeout(this.pendingSearch);