fix: allow returning from player detail to results

This commit is contained in:
bisco
2026-06-03 23:15:30 +02:00
parent f44a07f231
commit f87f62f111
4 changed files with 66 additions and 9 deletions
+27 -1
View File
@@ -126,6 +126,12 @@ button {
background: #e7eeeb;
}
.compact {
min-height: 34px;
padding: 0 10px;
white-space: nowrap;
}
.sort {
min-height: 30px;
padding: 0 10px;
@@ -152,12 +158,16 @@ button {
.workspace {
display: grid;
grid-template-columns: minmax(0, 1fr) 390px;
grid-template-columns: minmax(0, 1fr);
gap: 16px;
margin-top: 14px;
align-items: start;
}
.workspace.detail-open {
grid-template-columns: minmax(0, 1fr) 390px;
}
.table-wrap,
.detail {
background: var(--panel);
@@ -229,6 +239,13 @@ td small {
top: 14px;
}
.detail-header {
display: flex;
align-items: flex-start;
justify-content: space-between;
gap: 12px;
}
.role {
margin: 6px 0 0;
color: var(--muted);
@@ -311,6 +328,10 @@ dd {
grid-template-columns: 1fr;
}
.workspace.detail-open {
grid-template-columns: 1fr;
}
.table-wrap {
max-height: none;
}
@@ -364,6 +385,11 @@ dd {
h1 {
font-size: 2.6rem;
}
.detail-header {
display: grid;
grid-template-columns: 1fr;
}
}
@media (max-width: 520px) {
+4 -1
View File
@@ -81,7 +81,7 @@
<p *ngIf="errorMessage" class="alert">{{ errorMessage }}</p>
<section class="workspace" aria-label="Scouting workspace">
<section class="workspace" [class.detail-open]="selectedPlayer" aria-label="Scouting workspace">
<div class="table-wrap">
<table>
<thead>
@@ -129,11 +129,14 @@
</div>
<aside class="detail" *ngIf="selectedPlayer">
<div class="detail-header">
<div>
<p class="eyebrow">Selected profile</p>
<h2>{{ selectedPlayer.name }}</h2>
<p class="role">{{ selectedPlayer.position }} · {{ selectedPlayer.role || 'Role pending' }}</p>
</div>
<button type="button" class="secondary compact" (click)="returnToResults()">Back to results</button>
</div>
<div class="profile-strip">
<span>{{ selectedPlayer.nationality || '-' }}</span>
<span>{{ selectedPlayer.height_cm || '-' }} cm</span>
+16
View File
@@ -71,6 +71,7 @@ describe('AppComponent', () => {
assert.equal(component.resultCount, 2);
assert.equal(component.averagePoints, '14.00');
assert.equal(component.topEfficiencyPlayer?.name, 'Luca Marini');
assert.equal(component.selectedPlayer, null);
});
it('reacts to filter changes without requiring the search button', () => {
@@ -131,4 +132,19 @@ describe('AppComponent', () => {
assert.equal(component.players[0].name, 'Mateo Santos');
});
it('opens and closes a player profile without losing the filtered list', () => {
const api = {
searchPlayers: () => of({ count: samplePlayers.length, results: samplePlayers }),
} as unknown as PlayerApiService;
const component = new AppComponent(api);
component.search();
component.selectPlayer(samplePlayers[0]);
component.returnToResults();
assert.equal(component.selectedPlayer, null);
assert.equal(component.players.length, 2);
assert.equal(component.resultCount, 2);
});
});
+15 -3
View File
@@ -84,9 +84,10 @@ export class AppComponent {
this.playerApi.searchPlayers(this.filters).subscribe({
next: (response) => {
this.players = this.sortPlayers(response.results);
const players = this.sortPlayers(response.results);
this.players = players;
this.resultCount = response.count;
this.selectedPlayer = this.players[0] ?? null;
this.selectedPlayer = this.matchSelectedPlayer(players);
this.loading = false;
},
error: () => {
@@ -126,13 +127,17 @@ export class AppComponent {
sortBy(key: SortKey): void {
this.activeSort = key;
this.players = this.sortPlayers(this.players);
this.selectedPlayer = this.players[0] ?? null;
this.selectedPlayer = this.matchSelectedPlayer(this.players);
}
selectPlayer(player: PlayerSummary): void {
this.selectedPlayer = player;
}
returnToResults(): void {
this.selectedPlayer = null;
}
statValue(player: PlayerSummary, key: keyof NonNullable<PlayerSummary['stats']>): string {
const value = player.stats?.[key];
return value === undefined || value === null ? '-' : String(value);
@@ -170,6 +175,13 @@ export class AppComponent {
return Number(player.stats?.[key] ?? 0);
}
private matchSelectedPlayer(players: PlayerSummary[]): PlayerSummary | null {
if (!this.selectedPlayer) {
return null;
}
return players.find((player) => player.id === this.selectedPlayer?.id) ?? null;
}
private cancelPendingSearch(): void {
if (this.pendingSearch) {
clearTimeout(this.pendingSearch);