Player Search
- Filter players by profile, origin, context, and production metrics.
+ Filter players by profile, team-season context, and production metrics.
{% if search_has_errors %}
Please correct the highlighted filters.
@@ -56,8 +56,6 @@
{{ search_form.competition }}
{{ search_form.team }}
{{ search_form.season }}
-
{{ search_form.origin_competition }}
-
{{ search_form.origin_team }}
@@ -97,8 +95,6 @@
{{ search_form.three_pct_max }}
{{ search_form.ft_pct_min }}
{{ search_form.ft_pct_max }}
- {{ search_form.efficiency_metric_min }}
- {{ search_form.efficiency_metric_max }}
diff --git a/templates/players/partials/results.html b/templates/players/partials/results.html
index ff25c65..cfdf430 100644
--- a/templates/players/partials/results.html
+++ b/templates/players/partials/results.html
@@ -36,13 +36,18 @@
Player |
Nationality |
Pos / Role |
- Origin |
Height / Weight |
Best Eligible Games |
Best Eligible MPG |
Best Eligible PPG |
Best Eligible RPG |
Best Eligible APG |
+ Best Eligible SPG |
+ Best Eligible BPG |
+ Best Eligible TOV |
+ Best Eligible FG% |
+ Best Eligible 3P% |
+ Best Eligible FT% |
{% if request.user.is_authenticated %}Watchlist | {% endif %}
@@ -52,16 +57,18 @@
{{ player.full_name }} |
{{ player.nationality.name|default:"-" }} |
{{ player.nominal_position.code|default:"-" }} / {{ player.inferred_role.name|default:"-" }} |
-
- {{ player.origin_competition.name|default:"-" }}
- {% if player.origin_team %} {{ player.origin_team.name }} {% endif %}
- |
{{ player.height_cm|default:"-" }} / {{ player.weight_kg|default:"-" }} |
- {{ player.games_played_value|floatformat:0 }} |
- {{ player.mpg_value|floatformat:1 }} |
- {{ player.ppg_value|floatformat:1 }} |
- {{ player.rpg_value|floatformat:1 }} |
- {{ player.apg_value|floatformat:1 }} |
+ {% if player.games_played_value is not None %}{{ player.games_played_value|floatformat:0 }}{% else %}-{% endif %} |
+ {% if player.mpg_value is not None %}{{ player.mpg_value|floatformat:1 }}{% else %}-{% endif %} |
+ {% if player.ppg_value is not None %}{{ player.ppg_value|floatformat:1 }}{% else %}-{% endif %} |
+ {% if player.rpg_value is not None %}{{ player.rpg_value|floatformat:1 }}{% else %}-{% endif %} |
+ {% if player.apg_value is not None %}{{ player.apg_value|floatformat:1 }}{% else %}-{% endif %} |
+ {% if player.spg_value is not None %}{{ player.spg_value|floatformat:1 }}{% else %}-{% endif %} |
+ {% if player.bpg_value is not None %}{{ player.bpg_value|floatformat:1 }}{% else %}-{% endif %} |
+ {% if player.tov_value is not None %}{{ player.tov_value|floatformat:1 }}{% else %}-{% endif %} |
+ {% if player.fg_pct_value is not None %}{{ player.fg_pct_value|floatformat:1 }}{% else %}-{% endif %} |
+ {% if player.three_pct_value is not None %}{{ player.three_pct_value|floatformat:1 }}{% else %}-{% endif %} |
+ {% if player.ft_pct_value is not None %}{{ player.ft_pct_value|floatformat:1 }}{% else %}-{% endif %} |
{% if request.user.is_authenticated %}
{% if player.id in favorite_player_ids %}
diff --git a/tests/test_api.py b/tests/test_api.py
index 04a2be1..9117c6c 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -83,8 +83,6 @@ def test_players_api_search_consistent_with_ui_filters(client):
nationality=nationality,
nominal_position=position,
inferred_role=role,
- origin_competition=competition,
- origin_team=team,
)
ps = PlayerSeason.objects.create(
player=matching,
@@ -113,7 +111,7 @@ def test_players_api_search_consistent_with_ui_filters(client):
)
params = {
- "origin_competition": competition.id,
+ "competition": competition.id,
"nominal_position": position.id,
"points_per_game_min": "10",
"sort": "ppg_desc",
diff --git a/tests/test_players_filters_advanced.py b/tests/test_players_filters_advanced.py
index b133790..dfa5f9d 100644
--- a/tests/test_players_filters_advanced.py
+++ b/tests/test_players_filters_advanced.py
@@ -110,8 +110,6 @@ def test_player_search_combined_filters_sorting_and_pagination(client):
nationality=nationality,
nominal_position=position,
inferred_role=role,
- origin_competition=competition,
- origin_team=team,
)
player_season = PlayerSeason.objects.create(
player=player,
@@ -135,7 +133,7 @@ def test_player_search_combined_filters_sorting_and_pagination(client):
response = client.get(
reverse("players:index"),
data={
- "origin_competition": competition.id,
+ "competition": competition.id,
"nominal_position": position.id,
"sort": "ppg_desc",
"page_size": 20,
@@ -152,7 +150,7 @@ def test_player_search_combined_filters_sorting_and_pagination(client):
page2 = client.get(
reverse("players:index"),
data={
- "origin_competition": competition.id,
+ "competition": competition.id,
"nominal_position": position.id,
"sort": "ppg_desc",
"page_size": 20,
diff --git a/tests/test_players_views.py b/tests/test_players_views.py
index 7065000..96ef4ce 100644
--- a/tests/test_players_views.py
+++ b/tests/test_players_views.py
@@ -4,7 +4,7 @@ import pytest
from django.urls import reverse
from apps.competitions.models import Competition, Season
-from apps.players.models import Nationality, Player, PlayerAlias, Position, Role
+from apps.players.models import Nationality, Player, Position, Role
from apps.stats.models import PlayerSeason, PlayerSeasonStats
from apps.teams.models import Team
@@ -127,14 +127,13 @@ def test_player_detail_page_loads(client):
height_cm=201,
weight_kg=95,
)
- PlayerAlias.objects.create(player=player, alias="P. Martin")
-
response = client.get(reverse("players:detail", kwargs={"pk": player.pk}))
assert response.status_code == 200
body = response.content.decode()
assert "Paul Martin" in body
- assert "P. Martin" in body
+ assert "Summary" in body
+ assert "Season-by-Season Stats" in body
@pytest.mark.django_db
@@ -242,3 +241,44 @@ def test_player_search_results_render_best_eligible_metric_labels(client):
assert "Best Eligible PPG" in body
assert "Best Eligible MPG" in body
assert "best eligible values per player" in body.lower()
+
+
+@pytest.mark.django_db
+def test_player_search_results_render_dash_for_missing_eligible_metrics(client):
+ nationality = Nationality.objects.create(name="Norway", iso2_code="NO", iso3_code="NOR")
+ position = Position.objects.create(code="PF", name="Power Forward")
+ role = Role.objects.create(code="big", name="Big")
+ season = Season.objects.create(label="2025-2026", start_date=date(2025, 9, 1), end_date=date(2026, 6, 30))
+ competition = Competition.objects.create(
+ name="BLNO",
+ slug="blno",
+ competition_type=Competition.CompetitionType.LEAGUE,
+ gender=Competition.Gender.MEN,
+ country=nationality,
+ )
+ team = Team.objects.create(name="Oslo", slug="oslo", country=nationality)
+
+ player = Player.objects.create(
+ first_name="Ole",
+ last_name="NoStats",
+ full_name="Ole NoStats",
+ birth_date=date(2001, 1, 1),
+ nationality=nationality,
+ nominal_position=position,
+ inferred_role=role,
+ )
+ PlayerSeason.objects.create(
+ player=player,
+ season=season,
+ team=team,
+ competition=competition,
+ games_played=0,
+ minutes_played=0,
+ )
+
+ response = client.get(reverse("players:index"), data={"season": season.id})
+ assert response.status_code == 200
+ body = response.content.decode()
+ assert "Ole NoStats" in body
+ # Missing eligible values are rendered as '-' rather than misleading zeros.
+ assert body.count(">-") > 0
|