fix(v2-import): namespace source identity for snapshot upserts

tests/test_import_snapshots_command.py

@@ -51,6 +51,14 @@ def _valid_payload() -> dict:
     }
 
 
+def _valid_payload_for_source(source_name: str, *, competition_name: str = "NBA", team_name: str = "Los Angeles Lakers") -> dict:
+    payload = _valid_payload()
+    payload["source_name"] = source_name
+    payload["records"][0]["competition_name"] = competition_name
+    payload["records"][0]["team_name"] = team_name
+    return payload
+
+
 def _write_json(path: Path, payload: dict) -> None:
     path.write_text(json.dumps(payload), encoding="utf-8")
 
@@ -87,9 +95,9 @@ def test_valid_snapshot_import(tmp_path, settings):
     assert (archive / "nba-2026-03-13.json").exists()
     assert not (incoming / "nba-2026-03-13.json").exists()
 
-    assert Competition.objects.filter(source_uid="comp-nba").exists()
-    assert Team.objects.filter(source_uid="team-lal").exists()
-    assert Player.objects.filter(source_uid="player-23").exists()
+    assert Competition.objects.filter(source_name="official_site_feed", source_uid="comp-nba").exists()
+    assert Team.objects.filter(source_name="official_site_feed", source_uid="team-lal").exists()
+    assert Player.objects.filter(source_name="official_site_feed", source_uid="player-23").exists()
     assert Season.objects.filter(source_uid="season:2025-2026").exists()
     assert PlayerSeason.objects.count() == 1
     assert PlayerSeasonStats.objects.count() == 1
@@ -187,3 +195,59 @@ def test_same_run_second_file_same_checksum_is_skipped(tmp_path, settings):
     assert files["a.json"].status == ImportFile.FileStatus.SUCCESS
     assert files["b.json"].status == ImportFile.FileStatus.SKIPPED
     assert files["a.json"].checksum == files["b.json"].checksum
+
+
+@pytest.mark.django_db
+def test_same_raw_external_ids_from_different_sources_do_not_collide(tmp_path, settings):
+    incoming = tmp_path / "incoming"
+    archive = tmp_path / "archive"
+    failed = tmp_path / "failed"
+    incoming.mkdir()
+    archive.mkdir()
+    failed.mkdir()
+
+    lba_payload = _valid_payload_for_source("lba", competition_name="Lega Basket Serie A", team_name="Virtus Bologna")
+    bcl_payload = _valid_payload_for_source("bcl", competition_name="Basketball Champions League", team_name="AEK Athens")
+
+    _write_json(incoming / "lba.json", lba_payload)
+    _write_json(incoming / "bcl.json", bcl_payload)
+
+    settings.STATIC_DATASET_INCOMING_DIR = str(incoming)
+    settings.STATIC_DATASET_ARCHIVE_DIR = str(archive)
+    settings.STATIC_DATASET_FAILED_DIR = str(failed)
+
+    call_command("import_snapshots")
+
+    assert Competition.objects.filter(source_uid="comp-nba").count() == 2
+    assert Team.objects.filter(source_uid="team-lal").count() == 2
+    assert Player.objects.filter(source_uid="player-23").count() == 2
+    assert Competition.objects.filter(source_name="lba", source_uid="comp-nba", name="Lega Basket Serie A").exists()
+    assert Competition.objects.filter(source_name="bcl", source_uid="comp-nba", name="Basketball Champions League").exists()
+    assert Team.objects.filter(source_name="lba", source_uid="team-lal", name="Virtus Bologna").exists()
+    assert Team.objects.filter(source_name="bcl", source_uid="team-lal", name="AEK Athens").exists()
+
+
+@pytest.mark.django_db
+def test_reimport_same_source_payload_remains_idempotent(tmp_path, settings):
+    incoming = tmp_path / "incoming"
+    archive = tmp_path / "archive"
+    failed = tmp_path / "failed"
+    incoming.mkdir()
+    archive.mkdir()
+    failed.mkdir()
+
+    payload = _valid_payload_for_source("lba")
+    _write_json(incoming / "lba-1.json", payload)
+
+    settings.STATIC_DATASET_INCOMING_DIR = str(incoming)
+    settings.STATIC_DATASET_ARCHIVE_DIR = str(archive)
+    settings.STATIC_DATASET_FAILED_DIR = str(failed)
+
+    call_command("import_snapshots")
+
+    _write_json(incoming / "lba-2.json", payload)
+    call_command("import_snapshots")
+
+    assert Competition.objects.filter(source_name="lba", source_uid="comp-nba").count() == 1
+    assert Team.objects.filter(source_name="lba", source_uid="team-lal").count() == 1
+    assert Player.objects.filter(source_name="lba", source_uid="player-23").count() == 1